Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in process_open_files around stoi vs stoul #6983

Merged
merged 1 commit into from Mar 3, 2021

Conversation

directionless
Copy link
Member

Inode is a uint32, not an int.

Fixes: #6977

Co-authored-by: Stefano Bonicatti stefano.bonicatti@gmail.com

@directionless
Copy link
Member Author

A quick grep did not turn up any other cases where we use regex to parse out \d+ and try to stoi it

@Smjert
Copy link
Member

Smjert commented Mar 2, 2021

Seems a rogue file has slipped in

@directionless
Copy link
Member Author

Seems a rogue file has slipped in

Embarrassingly, that's the second time too. Fixed

@directionless directionless added this to the 4.7.0 milestone Mar 3, 2021
Copy link
Member

@theopolis theopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@theopolis theopolis merged commit dcef5d5 into osquery:master Mar 3, 2021
@directionless directionless deleted the seph/issue6977 branch March 3, 2021 03:35
aikuchin pushed a commit to aikuchin/osquery that referenced this pull request Jul 11, 2023
…0 to master

* commit '943935789dbfb03b55db1471ed1595e1fd4ffe23': (119 commits)
  seccomp migrations
  Add 4.7.0 CHANGELOG (osquery#6985)
  ATC fails because journal_mode pragma is blocked by sqlite authorizer (osquery#6999)
  Always use BIGINT macro for 'long long' data (osquery#6986)
  chrome_extensions: Refactor the table, add tests (osquery#6780)
  Remove extraneous lenses directory for augues on macOS (osquery#6998)
  Update the info about macOS CI (osquery#6988)
  Make Group ID columns consistent across Windows tables (osquery#6987)
  Fix mem leak regression with Windows' sids API (osquery#6984)
  Fix error in process_open_files around stoi vs stoul (osquery#6983)
  Remove hash and yara table from fuzz harnesses (osquery#6972)
  Augeas Table: Don't autoload system lenses (osquery#6980)
  Augeas Table: Fix output bug (osquery#6981)
  Add concat and concat_ws functions (osquery#6927)
  Copy JSON objects to avoid MemoryPool buildup (osquery#6957)
  Fix CODEOWNERS syntax to allow committers and TSC (osquery#6975)
  augeas: Clear aug pointer on error (osquery#6973)
  Adds support for the computer field in Windows Eventlogs (osquery#6952)
  Add Shellbags table (osquery#6949)
  Implementation of VM metadata table for Yandex.Cloud (osquery#6961)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeatable intermittent crash on some CentOS Linux hosts
3 participants