Fix performance issue with the disk serializer #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the issue noted in #76. Keeping all historical results of queries in the HistoricalQueryResults struct makes serializing and deserializing those structs very, very slow as time goes on. By only storing the last execution of the query, we keep the performance constant, but we kill the feature where osquery can rebuild timelines without accessing logs. After talking it over, we decided that this isn't actually that big of a deal because, if you really wanted to rebuild the old data, you should be able to process the logs, similarly to bin log replication in MySQL.
|
I ran this through some performance tests / benchmarks and it seems to be working swimmingly. |
|
Looks good! |
marpaia
added a commit
that referenced
this pull request
Sep 2, 2014
Fix performance issue with the disk serializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the issue noted in #76. Keeping all historical results of
queries in the HistoricalQueryResults struct makes serializing and
deserializing those structs very, very slow as time goes on. By only
storing the last execution of the query, we keep the performance
constant, but we kill the feature where osquery can rebuild timelines
without accessing logs. After talking it over, we decided that this
isn't actually that big of a deal because, if you really wanted to
rebuild the old data, you should be able to process the logs, similarly
to bin log replication in MySQL.