Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/json-c: set cmake build type as minsizerel #1367

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

danielp96
Copy link
Contributor

By default json-c builds as debug instead of release.

Adding CMAKE_BUILD_TYPE=minsizerel ensures it does not add debug info and optimizes for file size.

Fixes #1328

By default json-c builds as debug instead of release.

Adding CMAKE_BUILD_TYPE=minsizerel ensures it does not
add debug info and also optimizes for file size.

Signed-off-by: Daniel Pineda <daniel.pineda@puri.sm>
@tlaurion
Copy link
Collaborator

tlaurion commented Apr 6, 2023

@danielp96 : awesome find!!!!! Thanks a lot for that!
Will check for build and redo build locally and compare lib and then merge!

@tlaurion
Copy link
Collaborator

tlaurion commented Apr 11, 2023

Clean rebuild of 46aa253 happening at https://app.circleci.com/pipelines/github/tlaurion/heads/1595/workflows/873227a3-d591-4f43-9b84-2ca07cc1cc89 for comparison.

@tlaurion
Copy link
Collaborator

tlaurion commented Apr 11, 2023

Extending from linuxboot/heads-wiki#70 (comment) on local build vs this PR build:

user@heads-tests:/tmp$ HASHES1=~/heads/build/x86/x230-hotp-maximized/hashes.txt
user@heads-tests:/tmp$ HASHES2=/tmp/hashes.txt
user@heads-tests:/tmp$ egrep '^[0-9a-f]{64}' $HASHES1 | while read line; do HASH_REF=$(echo $line|awk -F " " {'print $1'}); FILE_REF=$(echo $line|awk -F "/" {'print $NF'}); if ! grep -q "$HASH_REF" $HASHES2; then echo "$FILE_REF doesn't match";fi; done
tools.cpio doesn't match
libmbedcrypto.so.0 doesn't match
libgcrypt.so.20 doesn't match
fbwhiptail doesn't match
kexec doesn't match
busybox doesn't match
bash doesn't match
initrd.cpio.xz doesn't match
heads-x230-hotp-maximized-v0.2.0-1508-g46aa253-bottom.rom doesn't match
heads-x230-hotp-maximized-v0.2.0-1508-g46aa253.rom doesn't match

@tlaurion
Copy link
Collaborator

@danielp96 thanks for that fix.

@tlaurion tlaurion merged commit 5b9d952 into linuxboot:master Apr 11, 2023
@danielp96 danielp96 deleted the libjson-reproducibility branch May 16, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libjson reproducibility issue
2 participants