Legacy ROS releases have been moved to the snapshots repo.

[nuclearsandwich]

The changes described in https://discourse.ros.org/t/security-issue-on-ros-build-farm/9342/8 will remove unsupported ROS releases from the live ROS repositories. The packages for these releases are being migrated to the ROS Snapshots repositories.

This switches legacy releases to adding the snapshots key and using the snapshots http format for final snapshots.

[ruffsl]

This legacy template has only ever been applied to distros older than Indigo. I'm guessing ROS1 Jade will be migrated to snapshot as well? Or is the plan to eventually house/move all EOL distros out of package.ros.org and into snapshots.ros.org as they age out, e.g including Indigo and Lunar?

[nuclearsandwich]

I'm guessing ROS1 Jade will be migrated to snapshot as well?

Yes. Jade isn't being rebuilt and so when the next sync happens it will be removed from packages.ros.org.

Or is the plan to eventually house/move all EOL distros out of package.ros.org and into snapshots.ros.org as they age out, e.g including Indigo and Lunar?

Yes that's the plan so far. Lunar and Indigo (on Trusty) are being rebuilt this round so they'll remain on packages.ros.org for now but part of the wind-down process for ROS distributions as they reach end-of-support will be to move them to the snapshots repo with a final snapshot.

[nuclearsandwich]

@ruffsl I have no idea how to actually invoke the template generator and build new Dockerfiles.

[ruffsl]

Some older docs are here, but simply once this template PR is merged, then all one has to do is temporarily uncomment the EOL comments in the manifest.yaml and update the older Dockerfiles with create_dockerfolders:

git clone https://github.com/osrf/docker_images.git
cd docker_images/docker
docker build --no-cache --tag=osrf:docker .

./run bash
cd ros
./create_dockerfolders.py dir -d ./ -a
exit

git add ...
git commit ...

Then you'd want to revert the manifest.yaml to how is was and update the library manifest file (ros) so we can upstream the library manifest for ROS1 distros we still have on the library:

cd docker_images/docker

./run bash
cd ros
./create_dockerlibrary.py -m manifest.yaml -o ros
exit

git add ...
git commit ...

I can try this tomorrow; I'm a little tied up currently.

[nuclearsandwich]

I found those docs and worked backwards. I didn't end up using the manifest.yaml but instead individually triggered the scripts on each affected dockerfile. The results of that attempt are in osrf/docker_images#273

I'm a little tied up currently.

❤️ Take care of what you need to. This will keep.

[mikaelarguedas]

lgtm, with one inline question

[mikaelarguedas]

Merging, keeping in mind that this template currently applies only to distro older than hydro.

Ideas of how to apply templates to all EOL distros explored at osrf/docker_images#281