Deprecation warnings when compiling with ogre 1.9

[osrf-migration]

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

Discovered while reviewing pull request #883:

There's a lot of deprecation warnings when compiling gazebo against ogre 1.9:

warning: ‘virtual void Ogre::MovableObject::setUserAny(const Ogre::Any&)’ is deprecated
warning: ‘virtual void Ogre::MovableObject::setUserAny(const Ogre::Any&)’ is deprecated

Full text of warnings here

[osrf-migration]

Original comment by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).

---

it's gonna be ugly replacing all setUserAny with #if #else macros.

May be we should our own function that does the version check in just one place, e.g.

#!c++


void SetOgreUserAny(Ogre::MovableObject _obj, const Ogre::Any& _any)
{
  #if (OGRE_VERSION < ((1 << 16) | (9 << 8) | 0))
    ...
  #else
    ...
  #endif
}

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

I second Ian's idea. We could put that function in gazebo/rendering/ogre_inc.h

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

I third Ian's idea. We should put it in gazebo/rendering/ogre_gazebo.h

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

I believe this is not nessary, as long as we make the minimum version of OGRE 1.8. Both ogre 1.8 and 1.9 have the API function needed to fix the warning.

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

pull request #1354

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

• changed state from "new" to "resolved"

pull request #1354

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• set version to "all"

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• changed state from "resolved" to "closed"