HeightmapLODPlugin: add server/gui params #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This allows specifying separate LOD parameters for a server and GUI rendering instances. This could allow using more accurate parameters in the server for camera sensors, while using coarser parameters in the GUI to reduce the computational burden. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
CI looks ok to me; the new test cases have passed on Ubuntu and homebrew |
actually, the heightmap test is failing on homebrew, and has been for some time. I'll fix it for this PR |
CI looks fine now; the new heightmap tests is passing on Ubuntu and macOS this is ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows specifying separate Heightmap LOD parameters for a server and GUI rendering instances. This could allow using more accurate parameters in the server for camera sensors, while using coarser parameters in the GUI to reduce the computational burden.
An accessor for the
bool ScenePrivate::isServerflag was added toScene.hhin 2f8bbaa to support this feature.