Declare test dependencies in [test] extra #86
Conversation
Adding a test dependency on 'pytest' will cause colcon to use pytest when running the package's tests, which yields a better experience than the existing fallback to unittest.
| @@ -20,6 +20,13 @@ | |||
| ['resource/' + package_name]), | |||
| ], | |||
| install_requires=install_requires, | |||
| extras_require={ | |||
There was a problem hiding this comment.
I'm not against this, but in many of our other python packages we specify:
tests_require=['pytest'],
Any particular reason for the difference?
There was a problem hiding this comment.
From what I can tell, that option is largely deprecated, and maintainers are strongly encouraged to define test dependencies in another way. The method proposed here is fairly widely supported.
This ticket might have more info on the topic: colcon/colcon-core#444
There was a problem hiding this comment.
Sigh. That is going to be another round of deprecations we are probably going to have to fix for Ubuntu 24.04 (with whatever newer setuptools is in there).
But that's not your fault or the fault of this PR :). Approving.
| @@ -20,6 +20,13 @@ | |||
| ['resource/' + package_name]), | |||
| ], | |||
| install_requires=install_requires, | |||
| extras_require={ | |||
There was a problem hiding this comment.
Sigh. That is going to be another round of deprecations we are probably going to have to fix for Ubuntu 24.04 (with whatever newer setuptools is in there).
But that's not your fault or the fault of this PR :). Approving.
Adding a test dependency on 'pytest' will cause colcon to use pytest when running the package's tests, which yields a better experience than the existing fallback to unittest.