Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of pkg_resources from osrf_pycommon. #66

Merged
merged 6 commits into from
Feb 1, 2022

Commits on Aug 2, 2021

  1. Remove use of pkg_resources from osrf_pycommon.

    Replace it with the use of the more modern importlib*
    libraries.  There are a couple of reasons to do this:
    
    1.  pkg_resources is quite slow to import; on my machine,
    just firing up the python interpreter takes ~35ms, while
    firing up the python interpreter and importing pkg_resources
    takes ~175ms.  Firing up the python interpreter and importing
    importlib_metadata takes ~70ms.  Removing 100ms per invocation
    of the command-line both makes it speedier for users, and
    will speed up our tests (which call out to the command-line
    quite a lot).
    
    2.  pkg_resources is somewhat deprecated and being replaced
    by importlib.  https://importlib-metadata.readthedocs.io/en/latest/using.html
    describes some of it
    
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    clalancette committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    ab3aa90 View commit details
    Browse the repository at this point in the history
  2. depend on importlib-metadata everywhere

    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood authored and clalancette committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    fd238ad View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Fixes from review.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    clalancette committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    9e2ffde View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Configuration menu
    Copy the full SHA
    17a1f04 View commit details
    Browse the repository at this point in the history
  2. restrict suites to only include ones that have python3-importlib-meta…

    …data
    
    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    87f674a View commit details
    Browse the repository at this point in the history
  3. add note to README about release changes

    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    77cee07 View commit details
    Browse the repository at this point in the history