Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workarounds for Android #52

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Workarounds for Android #52

merged 1 commit into from
Aug 18, 2020

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Aug 11, 2020

Android does not have support for execinfo.h, this just avoid compiling code paths that use that.

@esteve
Workarounds for Android
4512f50 
Signed-off-by: Esteve Fernandez <esteve@apache.org>
clalancette
clalancette approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. I'll run CI on this.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

CI looks good. Thanks for the contribution, merging.

@clalancette clalancette merged commit 0bd6acc into osrf:dashing Aug 18, 2020
jacobperron pushed a commit that referenced this pull request Nov 10, 2020
@esteve @jacobperron
Workarounds for Android (#52)
6fe8e96 
Signed-off-by: Esteve Fernandez <esteve@apache.org>
jacobperron pushed a commit that referenced this pull request Nov 10, 2020
@esteve @jacobperron
Workarounds for Android (#52)
3234915 
Signed-off-by: Esteve Fernandez <esteve@apache.org>
This was referenced Nov 10, 2020
Merged
Merged
@jacobperron
Copy link
Contributor

I think we should have targeted master originally and then backported it. I've opened forward ports:

@clalancette
Copy link
Contributor

I think we should have targeted master originally and then backported it. I've opened forward ports:

Oh yeah, definitely. Sorry I had missed that.

jacobperron pushed a commit that referenced this pull request Nov 10, 2020
@esteve @jacobperron
Workarounds for Android (#52)
4157658 
Signed-off-by: Esteve Fernandez <esteve@apache.org>
jacobperron added a commit that referenced this pull request Nov 10, 2020
@jacobperron @esteve
Workarounds for Android (#52) (#60)
b06fbfa 
Signed-off-by: Esteve Fernandez <esteve@apache.org>

Co-authored-by: Esteve Fernandez <esteve@apache.org>
jacobperron added a commit that referenced this pull request Nov 10, 2020
@jacobperron @esteve
Workarounds for Android (#52) (#59)
b8497a4 
Signed-off-by: Esteve Fernandez <esteve@apache.org>

Co-authored-by: Esteve Fernandez <esteve@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@esteve @clalancette @jacobperron