Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

Adjust delay threshold #148

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Adjust delay threshold #148

merged 3 commits into from
Aug 24, 2020

Conversation

mxgrey
Copy link
Member

@mxgrey mxgrey commented Aug 12, 2020

When the delay on an itinerary accumulates to above some threshold, the adapter will attempt to replan the route. This PR adds some methods to the API so that the threshold can be set by the user. It also adds launch parameters for the backwards-compatible fleet adapter to adjust this threshold or to disable the behavior entirely.

Copy link
Contributor

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like you mentioned, there is no clear way to test these changes, let me know if you have any further ideas. The API changes look good, and I ran the both demos for an hour each and everything seems to be working great, thanks!

@mxgrey mxgrey merged commit 93365fb into master Aug 24, 2020
@mxgrey mxgrey deleted the feature/adjust_delay_timeout branch August 24, 2020 04:43
mxgrey added a commit that referenced this pull request Aug 24, 2020
mxgrey added a commit that referenced this pull request Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants