This repository has been archived by the owner on Jul 22, 2021. It is now read-only.
Rework Traffic Light API #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a rework of a traffic light API and provides a simple mock up of a "traffic light fleet manager" that can be used to test the traffic light fleet adapter in simulation.
Simulation results revealed that modifications were needed to the traffic light API in order to accommodate a more robust implementation. The implementation has not been finished yet, but this PR allows the reworked API to make it into RMF release 1.1.0. The implementation will be fixed in release 1.1.1 and the API will remain the same for that release.