Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

Natively display floorplan on rviz #78

Merged
merged 8 commits into from
Sep 22, 2020

Conversation

youliangtan
Copy link
Contributor

This feature will help in the visualization of the existing building floorplan on Rviz. Basically, these floorplans are those being annotated in TrafficEditor.

Floorplan will be generated and published within rmf_scedulle_visualizer to topic /floorplan, using classic ros occupancy grid msg format. Briefly speaking, the floorplan data here is decoded from buildingmap msg, provided by the building_map_server.

youliangtan added a commit to open-rmf/rmf_traffic_editor that referenced this pull request Sep 16, 2020
Non-critical change. This helps in debugging in here: osrf/rmf_schedule_visualizer#78
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks for visualizing floor plans via occupancy grids. Left a couple of comments for your consideration. Could you also help to update the changelog for this package?

.github/workflows/build_eloquent.yaml Outdated Show resolved Hide resolved
rmf_schedule_visualizer/src/main_rviz.cpp Outdated Show resolved Hide resolved
@Yadunund
Copy link
Member

CI is failing for foxy as the foxy branch in rmf_core has been merged into master and deleted. So can delete the -b foxy from

git clone https://github.com/osrf/rmf_core -b foxy

Can also delete the eloquent build file since we are no longer supporting eloquent. But that can be a separate PR

@youliangtan youliangtan force-pushed the feature/native_floorplan_publisher branch from d1872cb to b0dfdde Compare September 22, 2020 08:33
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed for foxy

@youliangtan
Copy link
Contributor Author

At the same time, removed eloquent build and update docs to foxy

@youliangtan youliangtan merged commit a4a499f into master Sep 22, 2020
@youliangtan youliangtan deleted the feature/native_floorplan_publisher branch September 22, 2020 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants