Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable QoS-mismatch events and set QoS structures #35

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

codebot
Copy link
Member

@codebot codebot commented Sep 11, 2020

Signed-off-by: Morgan Quigley morgan@osrfoundation.org

Copy link
Member

@gbiggs gbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going to break some unit tests, but we can clean those up later (i have to fix some others already anyway)

rmw_zenoh_cpp/src/rmw_event.cpp Outdated Show resolved Hide resolved
rmw_zenoh_cpp/src/rmw_event.cpp Outdated Show resolved Hide resolved
@codebot
Copy link
Member Author

codebot commented Sep 11, 2020

I'm doing a few more style fixes now, will add another commit momentarily after uncrustification

Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
@gbiggs gbiggs force-pushed the set_constant_qos_using_amazing_merge_skills branch from ba12ed0 to 16bd63e Compare September 11, 2020 07:14
@gbiggs
Copy link
Member

gbiggs commented Sep 11, 2020

LGTM

@codebot codebot merged commit f0a485d into main Sep 11, 2020
@codebot codebot deleted the set_constant_qos_using_amazing_merge_skills branch September 11, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants