Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve substitutions upon SecurityNodeActionExtension._setup_security() #3

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jun 2, 2021

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
…tions

Signed-off-by: William Woodall <william@osrfoundation.org>
@hidmic hidmic marked this pull request as ready for review June 8, 2021 17:58
@hidmic
Copy link
Contributor Author

hidmic commented Jun 14, 2021

Circling back. I think we need extra permissions here, don't why @wjwwood? @Arnatious would you mind?

@wjwwood
Copy link
Member

wjwwood commented Jun 14, 2021

Yeah, I'll poke people offline too.

@wjwwood
Copy link
Member

wjwwood commented Jun 14, 2021

I got permissions now, @Arnatious do you mind if I merge this (and other pull requests) or would you prefer to review and merge pull requests here?

@wjwwood
Copy link
Member

wjwwood commented Jun 14, 2021

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood
Copy link
Member

wjwwood commented Jun 14, 2021

I have to include nodl in the CI, I'll fix that shortly.

@wjwwood
Copy link
Member

wjwwood commented Jun 14, 2021

New CI with nodl:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood merged commit 99c92c7 into osrf:main Jun 15, 2021
@wjwwood wjwwood deleted the resolve-substitutions branch June 15, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants