Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[noetic] Edifice support #139

Merged
merged 3 commits into from
Mar 17, 2021
Merged

[noetic] Edifice support #139

merged 3 commits into from
Mar 17, 2021

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Summary

Support the upcoming Ignition release.

Test it

  1. Install Edifice nightlies: https://ignitionrobotics.org/docs/edifice/install_ubuntu
  2. Set the env var: export IGNITION_VERSION=edifice
  3. Compile against Noetic

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from caguero as a code owner March 16, 2021 23:29
@osrf-triage osrf-triage added this to Inbox in Core development Mar 16, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina moved this from Inbox to In review in Core development Mar 16, 2021
@chapulina chapulina added the ROS 1 ROS 1 label Mar 16, 2021
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment about some Foxy comments

README.md Show resolved Hide resolved
RELEASING.md Show resolved Hide resolved
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

The following packages have unmet dependencies:
 libignition-gazebo5-dev : Depends: libignition-fuel-tools6-dev but it is not going to be installed
                           Depends: libignition-gui5-dev but it is not going to be installed
                           Depends: libignition-physics4-dev but it is not going to be installed
                           Depends: libignition-sensors5-dev but it is not going to be installed
                           Depends: libignition-rendering5-dev but it is not going to be installed
                           Depends: libignition-transport10-log-dev but it is not going to be installed
                           Depends: libsdformat11-dev but it is not going to be installed
                           Depends: libignition-gazebo5 (= 4.999.999+nightly+git20210316+1r41b0ffa3074ca3900f9a05cec3ec3ec07ff61a92-1~focal) but it is not going to be installed
                           Depends: libignition-gazebo5-plugins (= 4.999.999+nightly+git20210316+1r41b0ffa3074ca3900f9a05cec3ec3ec07ff61a92-1~focal) but it is not going to be installed
 libignition-msgs7-dev : Depends: libignition-msgs7 (= 6.999.999+nightly+git20210316+1r53e5fcc8fff54832660b76cb2301daed1418a7c9-1~focal) but it is not going to be installed
 libignition-transport10-dev : Depends: libignition-transport10-core-dev but it is not going to be installed
                               Depends: libignition-transport10-log-dev but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

Thanks, @ahcorde . CI is fixed.

@chapulina chapulina merged commit 29db8c7 into noetic Mar 17, 2021
Core development automation moved this from In review to Done Mar 17, 2021
@chapulina chapulina deleted the chapulina/noetic/edifice branch March 17, 2021 19:57
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ROS 1 ROS 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants