Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight compilation speed up #184

Merged
merged 1 commit into from Oct 27, 2021
Merged

Slight compilation speed up #184

merged 1 commit into from Oct 27, 2021

Conversation

mjcarroll
Copy link
Collaborator

馃 Bug fix

Summary

Since we are building the library, we should link to the library. This prevents us from rebuilding convert.cpp and factories.cpp, which both take quite a while.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development Oct 27, 2021
Core development automation moved this from Inbox to In review Oct 27, 2021
@mjcarroll mjcarroll merged commit 7e49c03 into noetic Oct 27, 2021
@mjcarroll mjcarroll deleted the reduce_compilation branch October 27, 2021 21:08
Core development automation moved this from In review to Done Oct 27, 2021
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants