Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reminder to hit play to receive images. #237

Merged
merged 1 commit into from Apr 11, 2022
Merged

Added reminder to hit play to receive images. #237

merged 1 commit into from Apr 11, 2022

Conversation

joe28965
Copy link
Contributor

@joe28965 joe28965 commented Apr 7, 2022

New feature

Closes #236

Summary

Added a reminder to hit play in Ignition Gazebo to receive images in example 2.
I didn't initially know this and it took me a while to realize why I wasn't receiving images even though I followed the instructions to the letter.

@joe28965 joe28965 requested a review from chapulina as a code owner April 7, 2022 13:47
@joe28965
Copy link
Contributor Author

joe28965 commented Apr 7, 2022

@mjcarroll
The PR for #236

@chapulina
Copy link
Contributor

Thank you for the PR, @joe28965 ! Would you mind signing your commit for the DCO checker?

@chapulina chapulina added the ROS 2 ROS 2 label Apr 8, 2022
@chapulina chapulina added this to Inbox in Core development via automation Apr 8, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Apr 8, 2022
@chapulina chapulina added the documentation Improvements or additions to documentation label Apr 8, 2022
@mjcarroll mjcarroll linked an issue Apr 8, 2022 that may be closed by this pull request
Signed-off-by: joe28965 <joeptool@gmail.com>
@joe28965
Copy link
Contributor Author

joe28965 commented Apr 8, 2022

@chapulina DCO is fixed

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@chapulina chapulina merged commit c7f74b7 into gazebosim:ros2 Apr 11, 2022
Core development automation moved this from In review to Done Apr 11, 2022
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ROS 2 ROS 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README from ros_ign_bridge Example 2 issue
2 participants