-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github action CI for uploading to codecov #255
Conversation
ruby is inserting the following text into all printouts from the
|
0d74573
to
6345ff4
Compare
|
I'm able to reproduce the problem with |
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
=========================================
Coverage ? 86.45%
=========================================
Files ? 59
Lines ? 9051
Branches ? 0
=========================================
Hits ? 7825
Misses ? 1226
Partials ? 0 Continue to review full report at Codecov.
|
fd20329
to
78dca58
Compare
ok I think this is finally working and ready for review |
after this is merged, we can consider adding coverage checks to the build status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just a couple of suggestions.
Oh I just realized we should remove this file: https://github.com/osrf/sdformat/blob/c6dac91c7845b0c45611e4db338e240bd86049d8/codecov.yml#L1-L2 It was only needed with mercurial because the main branch defaults to |
While porting this to Ignition, I thought it would be nice to reduce duplication, so I came up with an alternative approach on #266. Let me know what you think. |
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
removed in a4fc1d7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want to block this while the other approach is under construction 🚧
* Add github action CI for uploading to codecov Signed-off-by: Steven Peters <scpeters@openrobotics.org> * Update codecov badge Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Follow-up to #254 submitted from
origin