Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github action CI for uploading to codecov #255

Merged
merged 5 commits into from
May 1, 2020
Merged

Add github action CI for uploading to codecov #255

merged 5 commits into from
May 1, 2020

Conversation

scpeters
Copy link
Member

Follow-up to #254 submitted from origin

@scpeters
Copy link
Member Author

ruby is inserting the following text into all printouts from the ign tool, which causes a UNIT_ign_TEST failure:

/usr/lib/ruby/vendor_ruby/rubygems/defaults/operating_system.rb:10: warning: constant Gem::ConfigMap is deprecated

@scpeters
Copy link
Member Author 

lcov: ERROR: no valid records found in tracefile coverage.info

@scpeters
Copy link
Member Author

I'm able to reproduce the problem with lcov after upgrading gcov to 7.5.0

@codecov-io
Copy link

codecov-io commented Apr 28, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@c6dac91). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #255   +/-   ##
=========================================
  Coverage          ?   86.45%           
=========================================
  Files             ?       59           
  Lines             ?     9051           
  Branches          ?        0           
=========================================
  Hits              ?     7825           
  Misses            ?     1226           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6dac91...19e4896. Read the comment docs.

@scpeters
Copy link
Member Author

ok I think this is finally working and ready for review

@scpeters
Copy link
Member Author

after this is merged, we can consider adding coverage checks to the build status

@scpeters scpeters mentioned this pull request Apr 28, 2020
Closed
2 tasks
chapulina
chapulina previously approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just a couple of suggestions.

.github/workflows/c-cpp.yml Outdated Show resolved Hide resolved
.github/workflows/c-cpp.yml Outdated Show resolved Hide resolved
@chapulina
Copy link
Contributor

Oh I just realized we should remove this file:

https://github.com/osrf/sdformat/blob/c6dac91c7845b0c45611e4db338e240bd86049d8/codecov.yml#L1-L2

It was only needed with mercurial because the main branch defaults to master.

@chapulina chapulina mentioned this pull request May 1, 2020
Closed
@chapulina chapulina dismissed their stale review May 1, 2020 06:33

Try the custom action approach

@chapulina
Copy link
Contributor

While porting this to Ignition, I thought it would be nice to reduce duplication, so I came up with an alternative approach on #266. Let me know what you think.

@scpeters
Add github action CI for uploading to codecov
0df5dba 
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
@scpeters
Update codecov badge
233c4f9 
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
@scpeters
Better name, more concise syntax
a3e2e3a 
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
@scpeters
rm codecov.yml
a4fc1d7 
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
@scpeters
Rename actions configuration file
19e4896 
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

scpeters commented May 1, 2020

Oh I just realized we should remove this file:

removed in a4fc1d7

chapulina
chapulina approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to block this while the other approach is under construction 🚧

@scpeters scpeters merged commit 9eb6b99 into master May 1, 2020
@scpeters scpeters deleted the actions_codecov branch May 1, 2020 23:29
scpeters added a commit that referenced this pull request Jun 2, 2020
@scpeters
Add github action CI for uploading to codecov (#255)
3eef00b 
* Add github action CI for uploading to codecov

Signed-off-by: Steven Peters <scpeters@openrobotics.org>

* Update codecov badge

Signed-off-by: Steven Peters <scpeters@openrobotics.org>
@chapulina chapulina mentioned this pull request Jul 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scpeters @codecov-io @chapulina