Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe the CMake variable BUILD_TESTING if it is defined #269

Merged
merged 1 commit into from
May 15, 2020

Conversation

traversaro
Copy link
Contributor

For backward compatibility if the BUILD_TESTING variable is not defined compile the tests.

Fix #208 .

In particular on Windows the test takes a long time to compile due to the embedde tinyxml that is recompiled for each test.

For backward compatibility if it is not defined compile the tests

Signed-off-by: Silvio <silvio.traversaro@iit.it>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@traversaro traversaro changed the title If defined observe the CMake variable BUILD_TESTING If it is defined observe the CMake variable BUILD_TESTING May 2, 2020
@scpeters scpeters changed the title If it is defined observe the CMake variable BUILD_TESTING Observe the CMake variable BUILD_TESTING if it is defined May 15, 2020
@scpeters scpeters merged commit e33839f into gazebosim:sdf9 May 15, 2020
scpeters added a commit to scpeters/sdformat that referenced this pull request May 18, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request May 28, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters pushed a commit to scpeters/sdformat that referenced this pull request Jul 7, 2020
)

For backward compatibility if it is not defined compile the tests

Signed-off-by: Silvio <silvio.traversaro@iit.it>
scpeters added a commit to scpeters/sdformat that referenced this pull request Jul 7, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters pushed a commit to scpeters/sdformat that referenced this pull request Jul 7, 2020
)

For backward compatibility if it is not defined compile the tests

Signed-off-by: Silvio <silvio.traversaro@iit.it>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to scpeters/sdformat that referenced this pull request Jul 7, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters pushed a commit that referenced this pull request Jul 9, 2020
For backward compatibility if it is not defined compile the tests

Signed-off-by: Silvio <silvio.traversaro@iit.it>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request Jul 9, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters pushed a commit to scpeters/sdformat that referenced this pull request Jul 17, 2020
)

For backward compatibility if it is not defined compile the tests

Signed-off-by: Silvio <silvio.traversaro@iit.it>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to scpeters/sdformat that referenced this pull request Jul 17, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters pushed a commit that referenced this pull request Jul 21, 2020
For backward compatibility if it is not defined compile the tests

Signed-off-by: Silvio <silvio.traversaro@iit.it>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request Jul 21, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
traversaro added a commit to traversaro/sdformat that referenced this pull request Sep 5, 2020
)

For backward compatibility if it is not defined compile the tests

Signed-off-by: Silvio <silvio.traversaro@iit.it>
traversaro pushed a commit to traversaro/sdformat that referenced this pull request Sep 5, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants