Error when //inertial/pose/@relative_to is non-default #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
azeey
requested changes
Jan 29, 2021
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
azeey
reviewed
Jan 29, 2021
jennuine
force-pushed
the
jennuine/inertial_pose_relative_to
branch
from
f5faa3d
to
78bd773
Compare
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
+ Coverage 87.67% 87.70% +0.03%
==========================================
Files 65 65
Lines 9223 9223
==========================================
+ Hits 8086 8089 +3
+ Misses 1137 1134 -3
Continue to review full report at Codecov.
|
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
azeey
approved these changes
Feb 3, 2021
azeey
reviewed
Feb 3, 2021
Migration.md
Outdated
| @@ -317,9 +301,12 @@ but with improved human-readability.. | |||
|
|
|||
| ### Deprecations | |||
|
|
|||
| 1. **inerial.sdf** `//inertial/pose/@relative_to` attribute is deprecated | |||
There was a problem hiding this comment.
Can you change this to say removed instead of deprecated?
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #380