tests: Ensure removed SDFormat elements raise errors in newer versions #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
EricCousineau-TRI
force-pushed
the
issue-327
branch
from
c3f0ea0
to
6a20ec6
Compare
|
FWIW Tested locally with following setup: |
EricCousineau-TRI
added this to In Review
in SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
brawner
approved these changes
Feb 11, 2021
scpeters
reviewed
Feb 11, 2021
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
EricCousineau-TRI
force-pushed
the
issue-327
branch
from
3be445e
to
fc26baf
Compare
scpeters
approved these changes
Feb 12, 2021
|
@EricCousineau-TRI Do you have merge privileges on this repo, or do you need someone to merge for you? |
|
Nope, no merge privileges (and it's good that I don't have 'em :P) - can you merge it? |
SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
automation
moved this from In Review
to Done
Feb 12, 2021
nkoenig
removed this from Done
in SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #327 (explicitly)
Follow-up to #481
Uses model setup from issue:
https://github.com/RobotLocomotion/drake/blob/ab20bf25d9e9c05f861d7b6905cd6ef4dd9950c7/examples/multibody/four_bar/four_bar.sdf#L249
\cc @brawner