-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Ensure removed SDFormat elements raise errors in newer versions #490
Conversation
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
c3f0ea0
to
6a20ec6
Compare
FWIW Tested locally with following setup: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me.
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
3be445e
to
fc26baf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@EricCousineau-TRI Do you have merge privileges on this repo, or do you need someone to merge for you? |
Nope, no merge privileges (and it's good that I don't have 'em :P) - can you merge it? |
Resolves #327 (explicitly)
Follow-up to #481
Uses model setup from issue:
https://github.com/RobotLocomotion/drake/blob/ab20bf25d9e9c05f861d7b6905cd6ef4dd9950c7/examples/multibody/four_bar/four_bar.sdf#L249
\cc @brawner