Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VRX_EXIT_ON_COMPLETION flag from VORC #25

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Remove VRX_EXIT_ON_COMPLETION flag from VORC #25

merged 1 commit into from
Dec 4, 2020

Conversation

mabelzhang
Copy link
Collaborator

Removes VRX_EXIT_ON_COMPLETION environment variable from run_trial.bash, so that the new SDF shutdown flag added in osrf/vorc#35 are respected.
(This change is needed because currently, the environment variable overwrites SDF parameters, by design. See osrf/vorc#35.)

What I have tested using the 2 branches in the pending PR above:

  • Gymkhana, to make sure container doesn't shut down after the gates
  • Stationkeeping, wayfinding, and perception, to make sure the container still shuts down

@mabelzhang
remove VRX_EXIT_ON_COMPLETION flag from bash script
07080ec 
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@mabelzhang mabelzhang mentioned this pull request Dec 4, 2020
Merged
@caguero caguero merged commit 12b6894 into vorc Dec 4, 2020
@mabelzhang mabelzhang deleted the fix_gymkhana_shutdown branch December 4, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mabelzhang @caguero