Skip to content
This repository has been archived by the owner on Dec 13, 2021. It is now read-only.

error should be the last type when returning multiple items #7

Closed
siddontang opened this issue Jun 6, 2018 · 2 comments · Fixed by #8
Closed

error should be the last type when returning multiple items #7

siddontang opened this issue Jun 6, 2018 · 2 comments · Fixed by #8

Comments

@siddontang
Copy link
Contributor

as golint warns: error should be the last type when returning multiple items
we should return the error as the last item, but in hookfs, nearly all the Interface functions break this rule.

I think we need to adjust them but this will break the compatibility. But I think it is worthwhile.

/cc @AkihiroSuda

@AkihiroSuda
Copy link
Member

+1, I think breaking compatibility is ok, because vendoring has been very popular in the Go world.

@siddontang
Copy link
Contributor Author

ok, I will improve it later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants