Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a tab system for service docs view #129

Merged

Conversation

MBuchalik
Copy link
Collaborator

This PR implements the features described in #127: The service docs view can now not only be explored using the groups tree, but also by Responsibles and by Teams.

If a ServiceDoc has no Responsible (or no Team), then this ServiceDoc will simply not be shown at all. In this case, the user of the application needs to switch to the groups tree view to find the ServiceDoc.

This PR contains the following changes:

  • Renaming from "Groups Tree" to "Service Docs Explorer". This resulted in quite a lot of changed files.
  • The implementation of the tabs and of the two new exploration options (i.e. the grouping by Responsibles and by Teams).
  • Fixes of two typos that I noticed while doing the refactorings.
  • Fix of the highligting of the menu items in the left menu: When the user opened the Graph View, the menu item on the left was highlighted. But when the user opened the Service Docs Explorer, the menu item would not get highlighted. This was because the matching was done on the full URL, i.e. we checked for the entire route path instead of just the starting part of it.

Screenshots

grafik
grafik
grafik
grafik

Copy link
Contributor

@georg-schwarz georg-schwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Maybe we can "unowned" services into their own "unowned" item in future PRs.

@MBuchalik MBuchalik merged commit 3400249 into riehlegroup:main Jan 21, 2023
@MBuchalik
Copy link
Collaborator Author

Maybe we can "unowned" services into their own "unowned" item in future PRs.

Sounds good! 👍

@MBuchalik MBuchalik deleted the 127-tab-system-for-service-docs-view branch January 21, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants