Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable encoding of Maven registries. #231

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Enable encoding of Maven registries. #231

merged 3 commits into from
Apr 4, 2024

Conversation

oliverchang
Copy link
Contributor

Fixes #208.

Fixes #208.

Signed-off-by: Oliver Chang <ochang@google.com>
@oliverchang
Copy link
Contributor Author

@darakian @cuixq for review as well.

@cuixq
Copy link

cuixq commented Mar 26, 2024

LGTM!

Copy link
Collaborator

@chrisbloom7 chrisbloom7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@oliverchang
Copy link
Contributor Author

Thanks @cuixq and @chrisbloom7 :)

@darakian do you have any comments on this? Wanted to hear your thoughts also.

@darakian
Copy link
Contributor

@oliverchang, sorry for the delay. My only comment is that I think it's worth adding a fully formed example for an alternate registry. Using the first artifact I see on maven.google.com; I believe this could be
Maven:maven.google.com/android.arch.core:common

Otherwise, looks good to me 👍

@oliverchang
Copy link
Contributor Author

@oliverchang, sorry for the delay. My only comment is that I think it's worth adding a fully formed example for an alternate registry. Using the first artifact I see on maven.google.com; I believe this could be Maven:maven.google.com/android.arch.core:common

Otherwise, looks good to me 👍

Thanks! Hm, the group ID / artifact ID is not part of the ecosystem string here. It's instead part of the name field. Perhaps I could clarify that the name is in the groupID:artifactID format ?

oliverchang and others added 2 commits April 5, 2024 10:04
Signed-off-by: Oliver Chang <oliverchang@users.noreply.github.com>
Signed-off-by: Oliver Chang <ochang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Supporting Maven registries
4 participants