Skip to content

Commit

Permalink
Fix CodeReview bug (#1058)
Browse files Browse the repository at this point in the history
Co-authored-by: Azeem Shaikh <azeems@google.com>
  • Loading branch information
azeemshaikh38 and azeemsgoogle committed Sep 24, 2021
1 parent fb77e42 commit 0074111
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions checks/code_review.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ func githubCodeReview(c *checker.CheckRequest) (int, string, error) {
// of equivalent to a review and is done several times on small prs to save
// time on clicking the approve button.
if !foundApprovedReview &&
pr.MergeCommit.Committer.Login != "" &&
pr.MergeCommit.Committer.Login != pr.Author.Login {
c.Dlogger.Debug3(&checker.LogMessage{
Text: fmt.Sprintf("found PR#%d with committer (%s) different from author (%s)",
Expand Down

0 comments on commit 0074111

Please sign in to comment.