Skip to content

Commit

Permalink
Show negative results in Signed-Releases details
Browse files Browse the repository at this point in the history
Negative results logged with a "!!" prefix.

Updates #95

$ go run . --repo=github.com/gohugoio/hugo --show-details --checks=Signed-Releases
Starting [Signed-Releases]
Finished [Signed-Releases]

RESULTS
-------
Signed-Releases: Fail 10
    release found: v0.79.1
    !! release v0.79.1 has no signed artifacts
    release found: v0.79.0
    !! release v0.79.0 has no signed artifacts
    release found: v0.78.2
    !! release v0.78.2 has no signed artifacts
    release found: v0.78.1
    !! release v0.78.1 has no signed artifacts
    release found: v0.78.0
    !! release v0.78.0 has no signed artifacts
    release found: v0.77.0
    !! release v0.77.0 has no signed artifacts
    found signed artifacts for 0 of 6 releases
  • Loading branch information
moorereason committed Dec 20, 2020
1 parent eb0d488 commit 348bedb
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion checks/signed_releases.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ func SignedReleases(c checker.Checker) checker.CheckResult {
return checker.RetryResult(err)
}

artifactExtensions := []string{".asc", ".minisig", ".sig"}

totalReleases := 0
totalSigned := 0
for _, r := range releases {
Expand All @@ -47,7 +49,7 @@ func SignedReleases(c checker.Checker) checker.CheckResult {
totalReleases++
signed := false
for _, asset := range assets {
for _, suffix := range []string{".asc", ".minisig", ".sig"} {
for _, suffix := range artifactExtensions {
if strings.HasSuffix(asset.GetName(), suffix) {
c.Logf("signed release artifact found: %s, url: %s", asset.GetName(), asset.GetURL())
signed = true
Expand All @@ -59,13 +61,19 @@ func SignedReleases(c checker.Checker) checker.CheckResult {
break
}
}
if !signed {
c.Logf("!! release %s has no signed artifacts", r.GetName())
}
if totalReleases > releaseLookBack {
break
}
}

if totalReleases == 0 {
c.Logf("no releases found")
return checker.InconclusiveResult
}

c.Logf("found signed artifacts for %d of %d releases", totalSigned, totalReleases)
return checker.ProportionalResult(totalSigned, totalReleases, 0.8)
}

0 comments on commit 348bedb

Please sign in to comment.