Skip to content

Commit

Permalink
Also look for Differential Revision: to ensure that this repo uses Ph…
Browse files Browse the repository at this point in the history
…abricator

Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
  • Loading branch information
vihangm committed May 4, 2022
1 parent 1e2116b commit 366844a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion checks/evaluation/code_review.go
Expand Up @@ -203,7 +203,8 @@ func isReviewedOnPhabricator(c *checker.DefaultBranchCommit, dl checker.DetailLo
}

m := c.CommitMessage
if strings.Contains(m, "\nReviewed By: ") {
if strings.Contains(m, "\nDifferential Revision: ") &&
strings.Contains(m, "\nReviewed By: ") {
dl.Debug(&checker.LogMessage{
Text: fmt.Sprintf("commit %s was approved through %s", c.SHA, reviewPlatformPhabricator),
})
Expand Down

0 comments on commit 366844a

Please sign in to comment.