Tests updated to include validation for parsing

Improved the tests to include validation for parsing the URL.

pkg/scorecard.go

@@ -59,7 +59,7 @@ func (r *RepoURL) Set(s string) error {
 	}
 
 	if len(strings.TrimSpace(split[0])) == 0 || len(strings.TrimSpace(split[1])) == 0 {
-		log.Fatalf("invalid repo flag: [%s] pass the full repository URL", s)
+		log.Fatalf("invalid repo flag: [%s], pass the full repository URL", s)
 	}
 
 	r.Host, r.Owner, r.Repo = u.Host, split[0], split[1]

pkg/scorecard_test.go

@@ -37,30 +37,30 @@ func TestRepoURL_Set(t *testing.T) {
 			name: "Valid http address",
 			fields: fields{
 				Host:  "github.com",
-				Owner: "kubeflow",
+				Owner: "foo",
 				Repo:  "kubeflow",
 			},
-			args:    args{s: "https://github.com/kubeflow/kubeflow"},
+			args:    args{s: "https://github.com/foo/kubeflow"},
 			wantErr: false,
 		},
 		{
 			name: "Valid http address with trailing slash",
 			fields: fields{
 				Host:  "github.com",
-				Owner: "kubeflow",
+				Owner: "foo",
 				Repo:  "kubeflow",
 			},
-			args:    args{s: "https://github.com/kubeflow/kubeflow/"},
+			args:    args{s: "https://github.com/foo/kubeflow/"},
 			wantErr: false,
 		},
 		{
 			name: "Non github repository",
 			fields: fields{
 				Host:  "gitlab.com",
-				Owner: "kubeflow",
+				Owner: "foo",
 				Repo:  "kubeflow",
 			},
-			args:    args{s: "https://gitlab.com/kubeflow/kubeflow"},
+			args:    args{s: "https://gitlab.com/foo/kubeflow"},
 			wantErr: true,
 		},
 	}
@@ -71,9 +71,21 @@ func TestRepoURL_Set(t *testing.T) {
 				Owner: tt.fields.Owner,
 				Repo:  tt.fields.Repo,
 			}
+			t.Log("Test")
 			if err := r.Set(tt.args.s); (err != nil) != tt.wantErr {
 				t.Errorf("RepoURL.Set() error = %v, wantErr %v", err, tt.wantErr)
 			}
+			if !tt.wantErr {
+				if tt.fields.Host != r.Host {
+					t.Errorf("Repo Host expected to be %s but got %s", tt.fields.Host, r.Host)
+				}
+				if tt.fields.Owner != r.Owner {
+					t.Errorf("Repo owner expected to be %s but got %s", tt.fields.Owner, r.Owner)
+				}
+				if tt.fields.Repo != r.Repo {
+					t.Errorf("Repo expected to be %s but got %s", tt.fields.Repo, r.Repo)
+				}
+			}
 		})
 	}
 }