Log runtime failures in cron job (#840)

Co-authored-by: Azeem Shaikh <azeems@google.com>
ossf · Aug 11, 2021 · 977c2b8 · 977c2b8
1 parent 20370f7
commit 977c2b8
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/cron/worker/main.go b/cron/worker/main.go
@@ -95,14 +95,17 @@ func processRequest(ctx context.Context,
 		if err != nil {
 			return fmt.Errorf("error during RunScorecards: %w", err)
 		}
-		if !(*ignoreRuntimeErrors) {
-			for checkIndex := range result.Checks {
-				check := &result.Checks[checkIndex]
-				if errors.As(check.Error2, &sce.ErrScorecardInternal) {
-					// nolint: errorlint, goerr113
-					return fmt.Errorf("check %s has a runtime error: %v", check.Name, check.Error2)
-				}
+		for checkIndex := range result.Checks {
+			check := &result.Checks[checkIndex]
+			if !errors.As(check.Error2, &sce.ErrScorecardInternal) {
+				continue
 			}
+			errorMsg := fmt.Sprintf("check %s has a runtime error: %v", check.Name, check.Error2)
+			if !(*ignoreRuntimeErrors) {
+				// nolint: goerr113
+				return errors.New(errorMsg)
+			}
+			log.Print(errorMsg)
 		}
 		result.Date = batchRequest.GetJobTime().AsTime().Format("2006-01-02")
 		if err := result.AsJSON(true /*showDetails*/, zapcore.InfoLevel, &buffer); err != nil {