comment

checks/cii_best_practices.go

@@ -32,7 +32,7 @@ func init() {
 	}
 }
 
-// CodeReview will check if the maintainers perform code review.
+// CheckCIIBestPractices will check if the maintainers has a CII badge.
 func CIIBestPractices(c *checker.CheckRequest) checker.CheckResult {
 	rawData, err := raw.CIIBestPractices(c)
 	if err != nil {

pkg/json_raw_results.go

@@ -119,17 +119,13 @@ type jsonIssue struct {
 	// TODO: add fields, e.g., state=[opened|closed]
 }
 
-type jsonRawResults struct {
-	// List of recent issues.
-	RecentIssues []jsonIssue `json:"issues"`
-	// List of vulnerabilities.
-}
-
 type jsonOssfBestPractices struct {
 	Badge string `json:"badge"`
 }
 
 type jsonRawResults struct {
+	// Issues.
+	RecentIssues []jsonIssue `json:"issues"`
 	// OSSF best practices badge.
 	OssfBestPractices jsonOssfBestPractices `json:"openssf-best-practices-badge"`
 	// Vulnerabilities.
@@ -208,15 +204,6 @@ func (r *jsonScorecardRawResult) setDefaultCommitData(commits []checker.DefaultB
 		return nil
 	}
 
-
-//nolint:unparam
-func (r *jsonScorecardRawResult) addOssfBestPracticesRawResults(cbp *checker.CIIBestPracticesData) error {
-	r.Results.OssfBestPractices.Badge = string(cbp.Badge)
-	return nil
-}
-
-//nolint:unparam
-func (r *jsonScorecardRawResult) addCodeReviewRawResults(cr *checker.CodeReviewData) error {
 	r.Results.DefaultBranchCommits = []jsonDefaultBranchCommit{}
 	for _, commit := range commits {
 		com := jsonDefaultBranchCommit{
@@ -262,6 +249,12 @@ func (r *jsonScorecardRawResult) addCodeReviewRawResults(cr *checker.CodeReviewD
 	return nil
 }
 
+//nolint:unparam
+func (r *jsonScorecardRawResult) addOssfBestPracticesRawResults(cbp *checker.CIIBestPracticesData) error {
+	r.Results.OssfBestPractices.Badge = string(cbp.Badge)
+	return nil
+}
+
 func (r *jsonScorecardRawResult) addCodeReviewRawResults(cr *checker.CodeReviewData) error {
 	return r.setDefaultCommitData(cr.DefaultBranchCommits)
 }