Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摉 Docs: Pinned dependency doc 2 #1004

Merged
merged 3 commits into from
Sep 14, 2021
Merged

馃摉 Docs: Pinned dependency doc 2 #1004

merged 3 commits into from
Sep 14, 2021

Conversation

david-a-wheeler
Copy link
Contributor

These commits improve the pinned dependency documentation
in the source file checks.yaml, then generate checks.md from that.

@david-a-wheeler
Modify pinned dependency docs in checks.yaml
39f9529 
The previous changes about pinned dependencies
modified the generated file checks.md, not the source
file checks.yaml. This commit modifies the correct
source file checks.yaml instead. It also tweaks the
text further (while we're at it).

Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
@david-a-wheeler
Check in result of make generate-docs
3976650 
We've modified checks.yaml to improve the pinned
dependency discussion. This checks in the result of
`make generate-docs` so that the docs are visible
on GitHub.

Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
@david-a-wheeler david-a-wheeler changed the title Pinned dependency doc 2 Docs: Pinned dependency doc 2 Sep 13, 2021
@david-a-wheeler
Copy link
Contributor Author

The build / validate test is broken for some reason. Key snippet:

cd tools
go mod tidy && go mod verify
all modules verified
protoc --go_out=../../../ cron/data/metadata.proto
protoc-gen-go: program not found or is not executable
Please specify a program using absolute path or make sure the program is available in your PATH system variable
--go_out: protoc-gen-go: Plugin failed with status code 1.
make: *** [Makefile:94: cron/data/metadata.pb.go] Error 1
Error: Process completed with exit code 2.

@david-a-wheeler david-a-wheeler changed the title Docs: Pinned dependency doc 2 Docs: Pinned dependency doc 2 馃摉 Sep 13, 2021
@david-a-wheeler david-a-wheeler changed the title Docs: Pinned dependency doc 2 馃摉 馃摉 Docs: Pinned dependency doc 2 Sep 13, 2021
@laurentsimon
Copy link
Contributor

The build / validate test is broken for some reason. Key snippet:

cd tools
go mod tidy && go mod verify
all modules verified
protoc --go_out=../../../ cron/data/metadata.proto
protoc-gen-go: program not found or is not executable
Please specify a program using absolute path or make sure the program is available in your PATH system variable
--go_out: protoc-gen-go: Plugin failed with status code 1.
make: *** [Makefile:94: cron/data/metadata.pb.go] Error 1
Error: Process completed with exit code 2.

@azeemsgoogle @naveensrinivasan

@azeemshaikh38 azeemshaikh38 merged commit aa2ed45 into ossf:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@david-a-wheeler @laurentsimon @azeemshaikh38