Use release tag name instead of name in log messages #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the release TagName instead of Name when reporting found releases.
An example of the problem using Name:
$ go run . --repo=github.com/magefile/mage --show-details --checks=Signed-Releases
Starting [Signed-Releases]
Finished [Signed-Releases]
RESULTS
-------
Signed-Releases: Fail 10
release found: Colors, working directory, some better errors
!! release Colors, working directory, some better errors has no signed artifacts
release found: Modules and go1.13 Fixes
!! release Modules and go1.13 Fixes has no signed artifacts
release found: v1.8.0 - Papercuts and Bug Fixes
!! release v1.8.0 - Papercuts and Bug Fixes has no signed artifacts
release found: v1.7.1
!! release v1.7.1 has no signed artifacts
release found: v1.7.0 Mage Imports
!! release v1.7.0 Mage Imports has no signed artifacts
release found: v1.6.2 Bug Fixes
!! release v1.6.2 Bug Fixes has no signed artifacts
found signed artifacts for 0 out of 6 releases
With this commit:
Signed-Releases: Fail 10
release found: v1.10.0
!! release v1.10.0 has no signed artifacts
release found: v1.9.0
!! release v1.9.0 has no signed artifacts
release found: v1.8.0
!! release v1.8.0 has no signed artifacts
release found: v1.7.1
!! release v1.7.1 has no signed artifacts
release found: v1.7.0
!! release v1.7.0 has no signed artifacts
release found: v1.6.2
!! release v1.6.2 has no signed artifacts
found signed artifacts for 0 out of 6 releases
inferno-chromium
approved these changes
Dec 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the release TagName instead of Name when reporting found releases.
An example of the problem using Name:
With this commit: