Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add ClusterFuzzLite to Fuzzing check. #1166

Merged
merged 3 commits into from
Oct 30, 2021
Merged

✨ Add ClusterFuzzLite to Fuzzing check. #1166

merged 3 commits into from
Oct 30, 2021

Conversation

oliverchang
Copy link
Contributor

Check for the existence of ".clusterfuzzlite/Dockerfile".

Fixes #1148.

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Add ClusterFuzzLite to existing Fuzzing check.

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

Check for the existence of ".clusterfuzzlite/Dockerfile".

Fixes #1148.
@github-actions
Copy link

Integration tests success for 8b051c13cca72ddd06f4e70b08cc57c71fbbfeb5

@github-actions
Copy link

Integration tests success for 54b04f8f44c39323e4779b57ac4782026b298ff9

Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

if e != nil {
return checker.CreateRuntimeErrorResult(CheckFuzzing, e)
}
if usingOSSFuzz {
return checker.CreateMaxScoreResult(CheckFuzzing,
"project is fuzzed in OSS-Fuzz")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we keep the log messages consistent project uses OSS-Fuzz?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, "fuzzed in OSS-Fuzz" sounds more accurate to me. Unlike ClusterFuzzLite it's a service that they use less directly.

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround here!

checks/fuzzing.go Show resolved Hide resolved
@github-actions
Copy link

Integration tests success for 0b5f1151b5056ba8acdeaac4eac51a7898ae900a

@github-actions
Copy link

Integration tests success for 2da1734ac067b9d96110e9ad1d5162544d705dde

@azeemshaikh38 azeemshaikh38 merged commit d3796f2 into main Oct 30, 2021
@azeemshaikh38 azeemshaikh38 deleted the cflite-check branch October 30, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add clusterfuzzlite support to Fuzzing check
4 participants