-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add ClusterFuzzLite to Fuzzing check. #1166
Conversation
Check for the existence of ".clusterfuzzlite/Dockerfile". Fixes #1148.
54b04f8
to
8b051c1
Compare
Integration tests success for 8b051c13cca72ddd06f4e70b08cc57c71fbbfeb5 |
Integration tests success for 54b04f8f44c39323e4779b57ac4782026b298ff9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
if e != nil { | ||
return checker.CreateRuntimeErrorResult(CheckFuzzing, e) | ||
} | ||
if usingOSSFuzz { | ||
return checker.CreateMaxScoreResult(CheckFuzzing, | ||
"project is fuzzed in OSS-Fuzz") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we keep the log messages consistent project uses OSS-Fuzz
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, "fuzzed in OSS-Fuzz" sounds more accurate to me. Unlike ClusterFuzzLite it's a service that they use less directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround here!
Integration tests success for 0b5f1151b5056ba8acdeaac4eac51a7898ae900a |
Integration tests success for 2da1734ac067b9d96110e9ad1d5162544d705dde |
Check for the existence of ".clusterfuzzlite/Dockerfile".
Fixes #1148.
Add ClusterFuzzLite to existing Fuzzing check.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: