Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Miscellaneous refactors to ease downstream consumption #1645

Merged
merged 16 commits into from
Feb 27, 2022
Merged

✨ Miscellaneous refactors to ease downstream consumption #1645

merged 16 commits into from
Feb 27, 2022

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Feb 16, 2022 •
edited

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • checker: Add NewLogger constructor for DetailLogger impl
  • checker: Add NewRunner constructor for Runner
  • cmd: Move command flags and validation into an options package
  • cmd: Move client accessors to githubrepo package
  • cmd: Move policy and enabled checks to policy package
  • cmd: Move results formatting to format package
  • Fixup lint warnings

Signed-off-by: Stephen Augustus foo@auggie.dev

Tested against ossf/allstar#114.

cc: @jeffmendoza

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@justaugustus justaugustus temporarily deployed to integration-test February 16, 2022 01:53 Inactive
@justaugustus justaugustus temporarily deployed to integration-test February 16, 2022 01:54 Inactive
@github-actions
Copy link

Integration tests success for
[0e0ac01]
(https://github.com/ossf/scorecard/actions/runs/1850434912)

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022 •
edited by codecov bot

Codecov Report

Merging #1645 (b42de44) into main (7610519) will increase coverage by 2.08%.
The diff coverage is 1.73%.

@@            Coverage Diff             @@
##             main    #1645      +/-   ##
==========================================
+ Coverage   58.50%   60.58%   +2.08%     
==========================================
  Files          58       58              
  Lines        5801     5907     +106     
==========================================
+ Hits         3394     3579     +185     
+ Misses       2170     2085      -85     
- Partials      237      243       +6

@github-actions
Copy link

Integration tests success for
[29f9cd8]
(https://github.com/ossf/scorecard/actions/runs/1850438705)

@justaugustus justaugustus temporarily deployed to integration-test February 16, 2022 02:14 Inactive
@github-actions
Copy link

Integration tests success for
[a14d103]
(https://github.com/ossf/scorecard/actions/runs/1850505498)

@justaugustus justaugustus mentioned this pull request Feb 16, 2022
Closed
@justaugustus justaugustus changed the title [WIP] Construct ✨ [WIP] Miscellaneous refactors to ease downstream consumption Feb 16, 2022
@justaugustus justaugustus marked this pull request as draft February 16, 2022 14:28
@justaugustus justaugustus temporarily deployed to integration-test February 16, 2022 14:42 Inactive
@github-actions
Copy link

Integration tests success for
[4e4795b]
(https://github.com/ossf/scorecard/actions/runs/1853410891)

@justaugustus justaugustus temporarily deployed to integration-test February 16, 2022 15:08 Inactive
@github-actions
Copy link

Integration tests success for
[fe71973]
(https://github.com/ossf/scorecard/actions/runs/1853547678)

@justaugustus justaugustus temporarily deployed to integration-test February 16, 2022 16:23 Inactive
@github-actions
Copy link

Integration tests success for
[aa712bc]
(https://github.com/ossf/scorecard/actions/runs/1853943335)

@justaugustus justaugustus temporarily deployed to integration-test February 16, 2022 17:13 Inactive
@justaugustus justaugustus temporarily deployed to integration-test February 16, 2022 17:15 Inactive
@github-actions
Copy link

Integration tests success for
[e00aaeb]
(https://github.com/ossf/scorecard/actions/runs/1854193192)

@github-actions
Copy link

Integration tests success for
[e3f9f95]
(https://github.com/ossf/scorecard/actions/runs/1854200579)

@justaugustus
[DROP] Stage command refactors
2a16d7d 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
cmd: Update to use refactored packages
58517cd 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
cmd: Move command flags and validation into an options package
bf4aa73 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
cmd: Move client accessors to githubrepo package
e09b721 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
cmd: Move policy and enabled checks to policy package
19979cf 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
cmd: Move results formatting to format package
d635bdb 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
Fixup lint warnings
4cda2eb 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
checker: Prefer Set prefixes for setters
382aaf7 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
checker: Use DetailLogger return value for NewLogger()
efd365a 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
checker: Add GetClients accessor
749c12a 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
Move FormatResults to pkg/
2b9e98b 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
checks: Add getter for all checks
3d8dde5 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
Fixup lint warnings
25bba32 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus justaugustus temporarily deployed to integration-test February 24, 2022 23:17 Inactive
@justaugustus justaugustus enabled auto-merge (squash) February 24, 2022 23:18
@github-actions
Copy link

Integration tests success for
[25bba32]
(https://github.com/ossf/scorecard/actions/runs/1895856470)

naveensrinivasan
naveensrinivasan approved these changes Feb 27, 2022
View reviewed changes
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I am OK with this change.

Scorecard automation moved this from Review in progress to Reviewer approved Feb 27, 2022
@naveensrinivasan naveensrinivasan mentioned this pull request Feb 27, 2022
Closed
2 tasks
azeemshaikh38
azeemshaikh38 approved these changes Feb 27, 2022
View reviewed changes
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test February 27, 2022 02:00 Inactive
@github-actions
Copy link

Integration tests success for
[b42de44]
(https://github.com/ossf/scorecard/actions/runs/1904791959)

@justaugustus justaugustus merged commit 7956ff4 into ossf:main Feb 27, 2022
Scorecard automation moved this from Reviewer approved to Done Feb 27, 2022
This was referenced Feb 27, 2022
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveensrinivasan naveensrinivasan naveensrinivasan approved these changes

@azeemshaikh38 azeemshaikh38 azeemshaikh38 approved these changes

@inferno-chromium inferno-chromium Awaiting requested review from inferno-chromium

@laurentsimon laurentsimon Awaiting requested review from laurentsimon

Assignees
No one assigned
Labels
None yet
Projects
Scorecard
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justaugustus @codecov-commenter @naveensrinivasan @azeemshaikh38