🌱 Switch from paths-ignore to changed-files action to skip required checks. #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y changes to pass CI, which are currently blocked waiting for these required checks which will never run due to the path filter. Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
added
the
github_actions
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
spencerschrock
commented
Dec 22, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
=======================================
Coverage 40.03% 40.03%
=======================================
Files 122 122
Lines 9865 9865
=======================================
Hits 3949 3949
Misses 5635 5635
Partials 281 281 |
|
Integration tests success for |
|
Thanks for this change! Looks good to me. |
…ince cloud build handles the images. Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Integration tests success for |
laurentsimon
approved these changes
Dec 27, 2022
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
…hecks. (ossf#2566) * Switch from paths-ignore to changed-files action. This allows doc only changes to pass CI, which are currently blocked waiting for these required checks which will never run due to the path filter. Signed-off-by: Spencer Schrock <sschrock@google.com> * Pin checkout action. Disable redundant docker build on push to main since cloud build handles the images. Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Spencer Schrock <sschrock@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Spencer Schrock sschrock@google.com
What kind of change does this PR introduce?
CI fix
What is the current behavior?
Due to path filtering, PRs which only change Markdown files will never run the steps in
docker.yml:scorecard/.github/workflows/docker.yml
Lines 20 to 30 in c6d7680
Since these checks are (currently) required, PRs which only change Markdown files can never be merged. See #2565 and #2508. As long as these checks are required, there's no native way to solve this for reasons summarized well in this blog post.
What is the new behavior (if this is a feature change)?**
A third party action is used to detect doc only changes. Since skipped checks count as passing for required checks, this allows for doc only changes to merge.
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
I tested this with a few PRs in a fork here:
spencerschrock/scorecard-test#3
spencerschrock/scorecard-test#8
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)