馃悰 Retain tag when remediating unpinned docker images. #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2595 +/- ##
==========================================
+ Coverage 40.20% 40.40% +0.19%
==========================================
Files 122 122
Lines 9896 9908 +12
==========================================
+ Hits 3979 4003 +24
+ Misses 5636 5624 -12
Partials 281 281 |
|
Integration tests success for |
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Spencer Schrock <sschrock@google.com>
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Apr 4, 2023
Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Spencer Schrock <sschrock@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Spencer Schrock sschrock@google.com
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
Tagged and unpinned images are detected, but the remediation suggestion discards the tag which is problematic for reasons pointed out in #2581.
What is the new behavior (if this is a feature change)?**
The Docker remediation code now maintains the tag, based on whatever is in the
PinnedAtfield of thechecker.Dependencystruct.Which issue(s) this PR fixes
Fixes #2581
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)