🌱 performance: run integration tests only on approved PRs #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhant Khare <Siddhantkhare2694@gmail.com>
Siddhant-K-code
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
spencerschrock
as code owners
Siddhant-K-code
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Integration tests success for |
naveensrinivasan
approved these changes
Jan 21, 2023
naveensrinivasan
changed the title
naveensrinivasan
had a problem deploying
to
integration-test
GitHub Actions
Failure
|
@Siddhant-K-code Thank you!! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2609 +/- ##
=======================================
Coverage 40.40% 40.40%
=======================================
Files 122 122
Lines 9908 9908
=======================================
Hits 4003 4003
Misses 5624 5624
Partials 281 281 |
naveensrinivasan
had a problem deploying
to
integration-test
GitHub Actions
Failure
spencerschrock
added a commit
that referenced
this pull request
Jan 23, 2023
This reverts commit a29182d.
spencerschrock
added a commit
that referenced
this pull request
Jan 23, 2023
This reverts commit a29182d. Signed-off-by: Spencer Schrock <sschrock@google.com>
2 tasks
naveensrinivasan
pushed a commit
that referenced
this pull request
Jan 23, 2023
This reverts commit a29182d. Signed-off-by: Spencer Schrock <sschrock@google.com>
naveensrinivasan
pushed a commit
that referenced
this pull request
Jan 23, 2023
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
Signed-off-by: Siddhant Khare <Siddhantkhare2694@gmail.com> Signed-off-by: Siddhant Khare <Siddhantkhare2694@gmail.com>
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Apr 4, 2023
Signed-off-by: Siddhant Khare <Siddhantkhare2694@gmail.com> Signed-off-by: Siddhant Khare <Siddhantkhare2694@gmail.com>
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a CI Performance Improvement.
What is the current behavior?
Currently, Integration tests take ~13m & every run on every PR (without approval).
What is the new behavior (if this is a feature change)?**
This Proposed changes will improve that & it would run Integration Test only on approved PRs.
Which issue(s) this PR fixes
Fixes #2603
Special notes for your reviewer
Does this PR introduce a user-facing change?
No