Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Initial implementation of go-git client #2720

Merged
merged 1 commit into from Mar 15, 2023

Conversation

azeemshaikh38
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 commented Mar 4, 2023

What kind of change does this PR introduce?

Initial implementation of RepoClient APIs using go-git. Note that this is not an implementation of RepoClient interface, but rather a handler to replace tarballHandler. Part of #1709.

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #2720 (116a057) into main (c20ed9e) will decrease coverage by 0.41%.
The diff coverage is 0.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2720      +/-   ##
==========================================
- Coverage   49.91%   49.51%   -0.41%     
==========================================
  Files         156      157       +1     
  Lines       11669    11795     +126     
==========================================
+ Hits         5825     5840      +15     
- Misses       5490     5601     +111     
  Partials      354      354              

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 9, 2023 15:28 — with GitHub Actions Inactive
@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) March 9, 2023 16:37
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 9, 2023 16:37 — with GitHub Actions Inactive
clients/git/client.go Show resolved Hide resolved
clients/git/client.go Show resolved Hide resolved
clients/git/client.go Outdated Show resolved Hide resolved
clients/git/client.go Show resolved Hide resolved
clients/git/client.go Show resolved Hide resolved
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 14, 2023 21:48 — with GitHub Actions Inactive
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 14, 2023 22:54 — with GitHub Actions Inactive
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 14, 2023 23:08 — with GitHub Actions Inactive
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 14, 2023 23:09 — with GitHub Actions Inactive
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 14, 2023 23:10 — with GitHub Actions Inactive
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 14, 2023 23:14 — with GitHub Actions Inactive
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 15, 2023 17:13 — with GitHub Actions Inactive
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 15, 2023 20:24 — with GitHub Actions Inactive
Copy link
Contributor

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for initial implementation. Some small nits

clients/git/gitrepo_suite_test.go Show resolved Hide resolved
clients/git/client.go Show resolved Hide resolved
clients/git/client.go Show resolved Hide resolved
clients/git/client.go Outdated Show resolved Hide resolved
clients/git/client.go Show resolved Hide resolved
clients/git/e2e_test.go Show resolved Hide resolved
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 15, 2023 21:13 — with GitHub Actions Inactive
@azeemshaikh38 azeemshaikh38 merged commit 8966abd into ossf:main Mar 15, 2023
36 of 37 checks passed
developer-guy pushed a commit to developer-guy/scorecard that referenced this pull request Mar 18, 2023
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Signed-off-by: Batuhan Apayd谋n <batuhan.apaydin@trendyol.com>
developer-guy pushed a commit to developer-guy/scorecard that referenced this pull request Mar 18, 2023
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Signed-off-by: Batuhan Apayd谋n <batuhan.apaydin@trendyol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants