Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Bump github.com/google/go-github from v38.1.0 to v53.2.0 #3327

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

thepwagner
Copy link
Contributor

What kind of change does this PR introduce?

Dependency upgrade.

What is the current behavior?

Scorecard currently uses v38.1.0, which is around 2 years old: https://github.com/google/go-github/releases/tag/v38.1.0

What is the new behavior (if this is a feature change)?**

Scorecard uses v53.2.0 .
This includes API for Repository Rules, so this PR allow development on #3326 to begin.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

First contribution, sorry if I missed something!

Does this PR introduce a user-facing change?

No.


Signed-off-by: Peter Wagner <peter.wagner@shopify.com>
Copy link
Contributor

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@thepwagner thepwagner temporarily deployed to gitlab July 28, 2023 16:43 — with GitHub Actions Inactive
@thepwagner thepwagner temporarily deployed to integration-test July 28, 2023 16:43 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #3327 (5271bfb) into main (707fe05) will decrease coverage by 11.33%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3327       +/-   ##
===========================================
- Coverage   72.83%   61.50%   -11.33%     
===========================================
  Files         173      173               
  Lines       12686    12686               
===========================================
- Hits         9240     7803     -1437     
- Misses       2941     4456     +1515     
+ Partials      505      427       -78     

@spencerschrock spencerschrock temporarily deployed to gitlab July 28, 2023 16:58 — with GitHub Actions Inactive
@spencerschrock spencerschrock enabled auto-merge (squash) July 28, 2023 16:58
@spencerschrock spencerschrock temporarily deployed to integration-test July 28, 2023 16:58 — with GitHub Actions Inactive
@spencerschrock spencerschrock merged commit b992be3 into ossf:main Jul 28, 2023
37 of 38 checks passed
@thepwagner thepwagner deleted the go-github-v53 branch July 28, 2023 17:23
ashearin pushed a commit to kgangerlm/scorecard-gitlab that referenced this pull request Nov 13, 2023
Signed-off-by: Peter Wagner <peter.wagner@shopify.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants