🌱 E2e Gitlab Issues #3343
Merged
🌱 E2e Gitlab Issues #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveensrinivasan
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
spencerschrock and
raghavkaul
as code owners
naveensrinivasan
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3343 +/- ##
===========================================
- Coverage 73.62% 61.89% -11.74%
===========================================
Files 178 178
Lines 12864 12864
===========================================
- Hits 9471 7962 -1509
- Misses 2854 4462 +1608
+ Partials 539 440 -99 |
naveensrinivasan
temporarily deployed
to
integration-test
GitHub Actions
Inactive
I have updated it. This is e2e tests for GitLab issues. The Gitlab issues API requires additional permissions that would prevent the normal token from fetching the issues. |
spencerschrock
approved these changes
Aug 3, 2023
- Add an E2E test for Gitlab repo issues - Add two tests: one for a repo with issues, one for a repo without issues [clients/gitlabrepo/issues_e2e_test.go] - Add an E2E test for Gitlab repo issues - Add two tests: one for a repo with issues, one for a repo without issues Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
- Remove copyright notice and associated code from `clients/gitlabrepo/issues_e2e_test.go` - Change `ListIssues` to return an error if `ListAllProjectMembers` is not available [clients/gitlabrepo/issues_e2e_test.go] - Remove copyright notice and associated code from `clients/gitlabrepo/issues_e2e_test.go` - Change `ListIssues` to return an error if `ListAllProjectMembers` is not available Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
- Update context of test from "Test list issues - GitLab" to "Test list issues errors - GitLab" - Change test to return errors when listing for issues with normal token [clients/gitlabrepo/issues_e2e_test.go] - Change context of test from "Test list issues - GitLab" to "Test list issues errors - GitLab" - Change test from "returns branches for the repo" to "returns errors when listing for issues with normal token" Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
naveensrinivasan
force-pushed
the
naveen/e2e/clients/gitlabrepo/issues.go
branch
from
d6f8659
to
a4b6825
Compare
naveensrinivasan
temporarily deployed
to
integration-test
GitHub Actions
Inactive
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* 🌱 Add E2E tests for Gitlab repo issues - Add an E2E test for Gitlab repo issues - Add two tests: one for a repo with issues, one for a repo without issues [clients/gitlabrepo/issues_e2e_test.go] - Add an E2E test for Gitlab repo issues - Add two tests: one for a repo with issues, one for a repo without issues Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com> * Improve issue e2e tests & error handling - Remove copyright notice and associated code from `clients/gitlabrepo/issues_e2e_test.go` - Change `ListIssues` to return an error if `ListAllProjectMembers` is not available [clients/gitlabrepo/issues_e2e_test.go] - Remove copyright notice and associated code from `clients/gitlabrepo/issues_e2e_test.go` - Change `ListIssues` to return an error if `ListAllProjectMembers` is not available Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com> * Improve GitLab issues error handling - Update context of test from "Test list issues - GitLab" to "Test list issues errors - GitLab" - Change test to return errors when listing for issues with normal token [clients/gitlabrepo/issues_e2e_test.go] - Change context of test from "Test list issues - GitLab" to "Test list issues errors - GitLab" - Change test from "returns branches for the repo" to "returns errors when listing for issues with normal token" Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com> --------- Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com> Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
E2e tests for Gitlab issues. The list issues will fail as it requires additional permissions.
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)