Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add E2E test for Gitlab repo webhooks #3346

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

naveensrinivasan
Copy link
Member

  • List the webhooks and check that there is at least one returned

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #3346 (654f40b) into main (f9b8d82) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3346   +/-   ##
=======================================
  Coverage   61.88%   61.88%           
=======================================
  Files         178      178           
  Lines       12862    12862           
=======================================
  Hits         7960     7960           
  Misses       4462     4462           
  Partials      440      440           

@naveensrinivasan naveensrinivasan temporarily deployed to gitlab August 4, 2023 21:50 — with GitHub Actions Inactive
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test August 4, 2023 21:50 — with GitHub Actions Inactive
@naveensrinivasan naveensrinivasan force-pushed the naveen/e2e/clients/gitlabrepo/webhooks branch from 898f1d1 to 0562a3b Compare August 4, 2023 21:56
@naveensrinivasan naveensrinivasan temporarily deployed to gitlab August 4, 2023 21:56 — with GitHub Actions Inactive
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test August 4, 2023 21:56 — with GitHub Actions Inactive
Copy link
Contributor

@raghavkaul raghavkaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

- List the webhooks and check that there is at least one returned

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
- Add a skipIfTokenIsNot check for GitLab
- Update the MakeGitlabRepo function to use a new URL

[clients/gitlabrepo/workflow_e2e_test.go]
- Add a skipIfTokenIsNot check for GitLab
- Update the MakeGitlabRepo function to use a new URL

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan naveensrinivasan force-pushed the naveen/e2e/clients/gitlabrepo/webhooks branch from 0562a3b to 654f40b Compare August 7, 2023 17:55
@naveensrinivasan naveensrinivasan temporarily deployed to gitlab August 7, 2023 17:55 — with GitHub Actions Inactive
@naveensrinivasan naveensrinivasan enabled auto-merge (squash) August 7, 2023 17:55
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test August 7, 2023 17:56 — with GitHub Actions Inactive
@naveensrinivasan naveensrinivasan merged commit 097f6c7 into main Aug 7, 2023
38 checks passed
@naveensrinivasan naveensrinivasan deleted the naveen/e2e/clients/gitlabrepo/webhooks branch August 7, 2023 18:03
ashearin pushed a commit to kgangerlm/scorecard-gitlab that referenced this pull request Nov 13, 2023
* 🌱 Add E2E test for Gitlab repo webhooks

- List the webhooks and check that there is at least one returned

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

* Update GitLab repo workflow for e2e tests

- Add a skipIfTokenIsNot check for GitLab
- Update the MakeGitlabRepo function to use a new URL

[clients/gitlabrepo/workflow_e2e_test.go]
- Add a skipIfTokenIsNot check for GitLab
- Update the MakeGitlabRepo function to use a new URL

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

---------

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants