✨ Check for static archives in Binary Artifacts #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Korczynski <david@adalogics.com>
DavidKorczynski
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
DavidKorczynski
temporarily deployed
to
gitlab
GitHub Actions
Inactive
DavidKorczynski
had a problem deploying
to
integration-test
GitHub Actions
Failure
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3454 +/- ##
==========================================
- Coverage 72.87% 66.81% -6.06%
==========================================
Files 185 185
Lines 13148 13149 +1
==========================================
- Hits 9582 8786 -796
- Misses 3044 3873 +829
+ Partials 522 490 -32 |
DavidKorczynski
temporarily deployed
to
integration-test
GitHub Actions
Inactive
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
Signed-off-by: David Korczynski <david@adalogics.com> Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
Static archives do not lead to score reduction in Binary Artifacts, although
.ofiles do and.acorrespond to a group of.ofiles.What is the new behavior (if this is a feature change)?**
Static archives lead to score reduction.
Did not add a test because only a few binary checks have these. It may also be in the interest of size for the repository not to have
.afiles stored?Which issue(s) this PR fixes
NONE
Special notes for your reviewer
None
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)