🌱 refactor: reorder branch protection tests progressively by tier #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogoteles08
requested review from
raghavkaul and
laurentsimon
and removed request for
a team
diogoteles08
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3881 +/- ##
==========================================
- Coverage 74.87% 70.33% -4.55%
==========================================
Files 223 223
Lines 15993 15993
==========================================
- Hits 11975 11248 -727
- Misses 3254 4029 +775
+ Partials 764 716 -48 |
|
This file will be changing substantially in #3759. I recommend holding off until after that to see if these changes are still necessary. |
|
This pull request has been marked stale because it has been open for 10 days with no activity |
diogoteles08
changed the title
Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
diogoteles08
force-pushed
the
refactor/reorder-tests-on-branch-protection-evaluation-test
branch
from
f4f85ff
to
b4e96b6
Compare
diogoteles08
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
@spencerschrock I've rebased it after #3759 . Please take a look if that makes sense to you |
|
This pull request has been marked stale because it has been open for 10 days with no activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor PR that only reorder some of the tests on checks/evaluation/branch_protection_test.go, to enhance readability. The file tests the evaluation of the Branch Protection check along different configurations, I'm reordering the tests as if they're progressively following the requirements of branch protection tiers.
I'm creating this PR mostly because when working on #3499 I didn't know where exactly to put new tests and sometime got lost navigating between them. This ordering should make it easier to navigate between the tests.
What kind of change does this PR introduce?
It's a refactor
This PR does not change any behavior or bring any breaking change