✨ announce where results are written #4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
requested review from
justaugustus and
raghavkaul
and removed request for
a team
Before this change, when running with '-o foo' the output would end with: ``` RESULTS ------- ``` This was rather confusing. There's of course many ways to make this more clear, this commit adds a log line announcing where the output is written to: ``` RESULTS ------- Writing to foo ``` Signed-off-by: Arnout Engelen <arnout@bzzt.net>
raboof
force-pushed
the
announce-output-file
branch
from
4478005
to
e76991f
Compare
raboof
changed the title
raghavkaul
approved these changes
Jun 6, 2024
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
The linter was added primarily from people writing to Lines 93 to 96 in 3da6db5 |
balteravishay
pushed a commit
to balteravishay/scorecard
that referenced
this pull request
Jun 12, 2024
Before this change, when running with '-o foo' the output would end with: ``` RESULTS ------- ``` This was rather confusing. There's of course many ways to make this more clear, this commit adds a log line announcing where the output is written to: ``` RESULTS ------- Writing to foo ``` Signed-off-by: Arnout Engelen <arnout@bzzt.net> Signed-off-by: balteraivshay <avishay.balter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Minor usability improvement
What is the current behavior?
When running with '-o foo' the output would end with:
What is the new behavior (if this is a feature change)?**
This was rather confusing. There's of course many ways to make this more clear, this commit adds a log line announcing where the output is written to:
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)