Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Export registered check names #518

Merged
merged 1 commit into from
May 27, 2021
Merged

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    In context of BUG: Cron job looping #512, removing checks which use ArchiveURL.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@azeemshaikh38 azeemshaikh38 changed the title Remove FrozenDeps, SecurityPolicy from cron job 🐛 Remove FrozenDeps, SecurityPolicy from cron job May 27, 2021
@github-actions
Copy link

Integration tests success for 9e2bcf9169e82dd5bcfa6988eb8cd9782b3ee257

@naveensrinivasan
Copy link
Member

naveensrinivasan commented May 27, 2021

Is this based on concrete evidence on these rollbacks?

I think we would want to investigate further before rolling back changes.

Thoughts?

@azeemshaikh38
Copy link
Contributor Author

Is this based on concrete evidence on these rollbacks?

I think we would want to investigate further before rolling back changes.

Thoughts?

I agree. However, I'm a bit desperate to get the cron job running again and since the long weekend is coming up I'm not sure if anyone will be looking into the root cause. So I want to see if this can help.

@laurentsimon
Copy link
Contributor

Is this based on concrete evidence on these rollbacks?
I think we would want to investigate further before rolling back changes.
Thoughts?

I agree. However, I'm a bit desperate to get the cron job running again and since the long weekend is coming up I'm not sure if anyone will be looking into the root cause. So I want to see if this can help.

shall we create a different branch for this sort of test? This way it does not affect the main branch and it will help merges, etc

@azeemshaikh38
Copy link
Contributor Author

Is this based on concrete evidence on these rollbacks?
I think we would want to investigate further before rolling back changes.
Thoughts?

I agree. However, I'm a bit desperate to get the cron job running again and since the long weekend is coming up I'm not sure if anyone will be looking into the root cause. So I want to see if this can help.

shall we create a different branch for this sort of test? This way it does not affect the main branch and it will help merges, etc

Fair enough. I updated the PR just to be a refactoring. Will push a locally built binary to remove these checks.

@azeemshaikh38 azeemshaikh38 changed the title 🐛 Remove FrozenDeps, SecurityPolicy from cron job 🌱 Export registered check names May 27, 2021
@github-actions
Copy link

Integration tests success for 970919cfaa35af7cbb4b66e3576a228d06b3275c

@naveensrinivasan
Copy link
Member

Is this based on concrete evidence on these rollbacks?
I think we would want to investigate further before rolling back changes.
Thoughts?

I agree. However, I'm a bit desperate to get the cron job running again and since the long weekend is coming up I'm not sure if anyone will be looking into the root cause. So I want to see if this can help.

shall we create a different branch for this sort of test? This way it does not affect the main branch and it will help merges, etc

Fair enough. I updated the PR just to be a refactoring. Will push a locally built binary to remove these checks.

Thanks @azeemshaikh38 !

@azeemshaikh38 azeemshaikh38 merged commit be8aa3d into main May 27, 2021
@azeemshaikh38 azeemshaikh38 deleted the azeems/cron_disable branch May 27, 2021 21:54
@laurentsimon
Copy link
Contributor

It may be useful to have a header to the latest.json files we produce, to indicate which checks were run or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants