-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Export registered check names #518
Conversation
Integration tests success for 9e2bcf9169e82dd5bcfa6988eb8cd9782b3ee257 |
Is this based on concrete evidence on these rollbacks? I think we would want to investigate further before rolling back changes. Thoughts? |
I agree. However, I'm a bit desperate to get the cron job running again and since the long weekend is coming up I'm not sure if anyone will be looking into the root cause. So I want to see if this can help. |
shall we create a different branch for this sort of test? This way it does not affect the main branch and it will help merges, etc |
Fair enough. I updated the PR just to be a refactoring. Will push a locally built binary to remove these checks. |
9e2bcf9
to
970919c
Compare
Integration tests success for 970919cfaa35af7cbb4b66e3576a228d06b3275c |
Thanks @azeemshaikh38 ! |
It may be useful to have a header to the latest.json files we produce, to indicate which checks were run or not. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
In context of BUG: Cron job looping #512, removing checks which use ArchiveURL.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.