Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Remove token-heavy checks from cron job #882

Merged
merged 2 commits into from
Aug 23, 2021
Merged

✨ Remove token-heavy checks from cron job #882

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab3b6a0
Remove token-heavy checks from cron job
azeemsgoogle Aug 23, 2021
adc93d5
Merge branch 'main' into azeems/token
azeemshaikh38 Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions cron/worker/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,12 +217,11 @@ func main() {
}()

checksToRun := checks.AllChecks
// nolint
// FIXME :- deleting branch-protection
// The branch protection check needs an admin access to the repository.
// All of the checks from cron would fail and uses another call to the API.
// This will reduce usage of the API.
delete(checksToRun, checks.CheckBranchProtection)
// TODO: Temporarily remove checks which require lot of GitHub API token.
delete(checksToRun, checks.CheckSAST)
delete(checksToRun, checks.CheckCITests)
// TODO: Re-add Contributors check after fixing: #859.
delete(checksToRun, checks.CheckContributors)
azeemshaikh38 marked this conversation as resolved.
Show resolved Hide resolved
for {
req, err := subscriber.SynchronousPull()
if err != nil {
Expand Down