Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SARIF 5: binary artifact check uses new structure #883

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

laurentsimon
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    no structured detail for binary artifacts

  • What is the new behavior (if this is a feature change)?

  • structured detail for binary artifacts

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@laurentsimon
Copy link
Contributor Author

@chrismcgehee FYI, this is an example to migrate an existing check to the new structure
We can start migrating checks now, even if #866 is not merged yet

@laurentsimon laurentsimon enabled auto-merge (squash) August 23, 2021 16:51
@laurentsimon laurentsimon merged commit d1de6cf into ossf:main Aug 23, 2021
Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants