Clarifications on Logo entitlement vs. Badge usage #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated language around badges per stage.
KennyPaul
added
documentation
marcelamelara
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Thanks @KennyPaul ! Can you please add a changelog entry for this process update?
|
LGTM, assuming addition of Changelog entry and DCO. |
This reverts commit e87da60.
steiza
approved these changes
Aug 16, 2024
|
@KennyPaul one more thing before we merge this PR. There seems to be one commit that's missing the git signoff, could you please resolve that? |
bobcallaway
approved these changes
Aug 16, 2024
|
Actually this is one where I need some education... Not sure why the DCO check barfed since I did sign off on b9d41d8 |
|
@KennyPaul We went ahead and merged since we squash-merged anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated language around badges per stage.