Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSCQuery interface displays value even with access mode 'Set' #661

Open
x37v opened this issue Dec 10, 2020 · 4 comments
Open

OSCQuery interface displays value even with access mode 'Set' #661

x37v opened this issue Dec 10, 2020 · 4 comments

Comments

@x37v
Copy link
Contributor

x37v commented Dec 10, 2020

I'm using the cpp98 interface. I have a node that should have 'Set' only access. I set it up like below.

auto n = root.create_string("cmd");
n.set_description("command handler");
n.set_access(opp::access_mode::Set);

Unfortunately this still displays the last string set in the json http response (without query strings), and the cmd?VALUE query string also returns the value.

The proposal indicates about value:

If a query is performed for the "VALUE" attribute, but the "ACCESS" attribute indicates that the OSC method isn't readable, the query should return a 204 (no content/inappropriate request).

ossia claims to support both Access and Value

@jcelerier
Copy link
Member

jcelerier commented Dec 13, 2020

Thanks for the report.
I guess we could have a "strict" mode by default which would respect the spec - the reason it's done like this is because in practice, lots of users asked fro the ability to see things anyways.

@jcelerier
Copy link
Member

paging @bltzr @jln- @avilleret for opinions

@x37v
Copy link
Contributor Author

x37v commented Dec 13, 2020

Thanks for the report.
I guess we could have a "strict" mode by default which would respect the spec - the reason it's done like this is because in practice, lots of users asked fro the ability to see things anyways.

Huh, I guess I don't get why those users don't just use the Bi mode? Maybe ossia doesn't allow you to LISTEN to a Set?

@avilleret
Copy link
Contributor

this seems related to #504

afaic since lots of people are complaining we are not strictly following the specs regarding access mode, I suggest to change to strictly follow the specs, even if it breaks some code somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants